Skip to content

Added support for passing tool_call_id via the RunContextWrapper#766

Merged
rm-openai merged 4 commits intoopenai:mainfrom
niv-hertz:main
Jun 9, 2025
Merged

Added support for passing tool_call_id via the RunContextWrapper#766
rm-openai merged 4 commits intoopenai:mainfrom
niv-hertz:main

Conversation

@niv-hertz
Copy link
Copy Markdown
Contributor

@niv-hertz niv-hertz commented May 27, 2025

This PR fixes issue: #559

By adding the tool_call_id to the RunContextWrapper prior to calling tools. This gives the ability to access the tool_call_id in the implementation of the tool.

@niv-hertz
Copy link
Copy Markdown
Contributor Author

niv-hertz commented May 27, 2025

@rm-openai - This addressed the issue we discussed in another thread, would love you review :)

rm-openai
rm-openai requested changes May 30, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@rm-openai rm-openai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for delayed review. Was thinking about it, and it feels a bit bad to have tool_call_id be nullable.

What if instead we had ToolContext subclass RunContextWrapper. That way, existing usecases would just work since the downcast is fine. And tool_call_id would be non-null always?

@niv-hertz
Copy link
Copy Markdown
Contributor Author

niv-hertz commented Jun 2, 2025 •
edited
Loading

Sorry for delayed review. Was thinking about it, and it feels a bit bad to have tool_call_id be nullable.

What if instead we had ToolContext subclass RunContextWrapper. That way, existing usecases would just work since the downcast is fine. And tool_call_id would be non-null always?

@rm-openai - I added a ToolContext object such that new users will be able to create tool functions that receive the ToolContext instead of the AgentContextWrapper. I also modified the internal FunctionTool class to only receive the ToolContext object in the on_invoke_tool params, so this change will break the type checking of anyone who uses the FunctionTool class directly instead of the wrappers. It seemed reasonable to me, let me know if you think otherwise.

@niv-hertz
Copy link
Copy Markdown
Contributor Author

niv-hertz commented Jun 6, 2025

@rm-openai - bumping this 😄

@niv-hertz niv-hertz requested a review from rm-openai June 9, 2025 12:34
rm-openai
rm-openai approved these changes Jun 9, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@rm-openai rm-openai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please just fix the typecheck etc and I can merge

Comment thread src/agents/tool_context.py Outdated
@niv-hertz niv-hertz requested a review from rm-openai June 9, 2025 14:55
@rm-openai rm-openai merged commit 8dfd6ff into openai:main Jun 9, 2025
5 checks passed
@rm-openai
Copy link
Copy Markdown
Collaborator

rm-openai commented Jun 9, 2025

awesome thanks for implementing this!

KatHaruto pushed a commit to KatHaruto/openai-agents-python that referenced this pull request Jun 10, 2025
@niv-hertz @KatHaruto
Added support for passing tool_call_id via the RunContextWrapper (ope…
3160557 
…nai#766)

This PR fixes issue:
openai#559

By adding the tool_call_id to the RunContextWrapper prior to calling
tools. This gives the ability to access the tool_call_id in the
implementation of the tool.
@daavoo daavoo mentioned this pull request Jun 19, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rm-openai rm-openai Awaiting requested review from rm-openai

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@niv-hertz @rm-openai